[apex] Deprecate ApexRootNode.getApexVersion #4280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assume Apex version is >= V176.
Generated by 🚫 Danger |
adangel
changed the title
adangel
added
the
is:deprecation
|
Note: I didn't find any indication, that the metadata would be parsed by jorje/lsp implementation. It's probably safe to say, that this Apex version never worked as intended. |
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Jan 14, 2023
adangel
added a commit
to adangel/pmd
that referenced
this pull request
Jan 14, 2023
…sion [apex] Deprecate ApexRootNode.getApexVersion pmd#4280
16 tasks
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the rules that utilize it. Assume Apex version is >= V176.
Describe the PR
This was discussed in #4251 in the context of replacing the Apex AST. This functionality is [feasible but] not planned for the new AST. It's also not fully certain how it behaves in the existing AST.
The two uses of
ApexRootNode.getApexVersionare in AbstractApexUnitTestRule.java and ApexUnitTestShouldNotUseSeeAllDataTrueRule.java. It determines whether to also visit test methods without@IsTestif they predate the@isTestintroduction API version 24. Assuming thatgetApexVersionactually parses the metadata API, this could lead to false negatives in rules that would otherwise fire on test-only code.