[java] CommentDefaultAccessModifier - add co.elastic.clients.util.VisibleForTesting as default suppressed annotation #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adangel
changed the title
adangel
requested changes
Jan 9, 2023
...main/java/net/sourceforge/pmd/lang/java/rule/codestyle/CommentDefaultAccessModifierRule.java
Outdated
Show resolved
Hide resolved
.../resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/CommentDefaultAccessModifier.xml
Outdated
Show resolved
Hide resolved
mluckam
force-pushed
the
elasticsearch_visiblefortesting
branch
from
3d24cb0
to
918aa04
Compare
suppressed annotations for rule CommentDefaultAccessModifierRule
Co-authored-by: Andreas Dangel <andreas.dangel@adangel.org>
mluckam
force-pushed
the
elasticsearch_visiblefortesting
branch
from
918aa04
to
f6504a6
Compare
adangel
changed the title
adangel
changed the title
Generated by 🚫 Danger |
adangel
added a commit
that referenced
this pull request
Jan 10, 2023
adangel
added a commit
that referenced
this pull request
Jan 10, 2023
[java] CommentDefaultAccessModifier - add co.elastic.clients.util.VisibleForTesting as default suppressed annotation #4285
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
The rule CommentDefaultAccessModifier ignores @VisibleForTesting as stated by the documentation:
This rule ignores by default all cases that have a @VisibleForTesting annotation or any JUnit5 annotation
https://pmd.github.io/pmd/pmd_rules_java_codestyle.html#commentdefaultaccessmodifier
This should also apply to the annotation co.elastic.clients.util.VisibleForTesting from the elastic provided java client, elasticsearch-java,.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)