-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Improve benchmarking #4365
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Recover the old behavior, where the number of rule applications is split from the number of tree transversals. - This means that rules that are applied, but didn't match any node where previously unlisted, but know show they were applied to all files, and evaluated 0 nodes. - We also count towards the rule's benchmark the cost of getting to the nodes it want's to evaluate, so poor xpath selectors actually show for the particular rule.
- The numbers relate to how they are executed, but don't necessarilly imply a required order (ie: Comment Assignment could be done at any point) - Since the benchmark report sorts by time spent on each one, the numbered labels are simply confusing
- First off, all LPS are benchmarked in the AstProcessor, having this here was inconsistent - Since these passes can be triggered by the symbol table LPS phase, we ended up double counting total time. - This however puts all disambiguation passes done for symbol table as symbol table cost, which although accurate, may not help to identify speed up opportunities as clearly, but the benchmark is not a profiling tool.
- Unnacounted time was significantly larger than it used to be, and in proportion tok about 10% of total execution time. Properly account attaining ruleset copies, TextDocuments, and overal parser and rule setup as processing time.
Generated by 🚫 Danger |
oowekyala
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Rule benchmarking:
Language Processing Stages:
Comment Assignment
could be done at any point in reality)AstDissambiguation Pass
track this was inconsistent.may not help to identify speed up opportunities as clearly, but the benchmark is not a profiling tool.
Unaccounted:
Ready?
./mvnw clean verify
passes (checked automatically by github actions)