Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] Update PMD_APEX_ROOT_DIRECTORY documentation reference #4452

Merged
merged 1 commit into from
Apr 13, 2023
Merged

[doc] Update PMD_APEX_ROOT_DIRECTORY documentation reference #4452

merged 1 commit into from
Apr 13, 2023

Conversation

nwcm
Copy link
Contributor

@nwcm nwcm commented Apr 4, 2023

Describe the PR

As per https://docs.pmd-code.org/latest/pmd_languages_configuration.html#apex-language-properties

Updating the document to clearly outline the correct property to set

Related issues

  • Fixes #

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@nwcm nwcm changed the title Update PMD_APEX_ROOT_DIRECTORY documenation reference [doc] Update PMD_APEX_ROOT_DIRECTORY documenation reference Apr 4, 2023
@adangel adangel added a:bug PMD crashes or fails to analyse a file. in:documentation Affects the documentation labels Apr 13, 2023
adangel
adangel approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Yes, it's with an additional underscore, since the property is called rootDirectory (notice the change in capitalization):

pmd/pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/ApexLanguageProperties.java

Line 18 in 0313ffd

PropertyFactory.stringProperty("rootDirectory")

@adangel adangel changed the title [doc] Update PMD_APEX_ROOT_DIRECTORY documenation reference [doc] Update PMD_APEX_ROOT_DIRECTORY documentation reference Apr 13, 2023
adangel added a commit that referenced this pull request Apr 13, 2023
@adangel
[doc] Update release notes (#4452)
0d73abb
adangel added a commit that referenced this pull request Apr 13, 2023
@adangel
Merge pull request #4452 from nwcm:patch-1
c36a22e 
[doc] Update PMD_APEX_ROOT_DIRECTORY documentation reference #4452
@adangel adangel merged commit 702318a into pmd:master Apr 13, 2023
@adangel adangel added this to the 7.0.0 milestone Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
a:bug PMD crashes or fails to analyse a file. in:documentation Affects the documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nwcm @adangel