Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #4063: False-negative about try/catch block in Loop #4533

Merged
merged 3 commits into from
May 19, 2023
Merged

[java] Fix #4063: False-negative about try/catch block in Loop #4533

merged 3 commits into from
May 19, 2023

Conversation

LynnBroe
Copy link
Contributor

@LynnBroe LynnBroe commented May 2, 2023 •
edited by adangel
Loading

Describe the PR

This PR consider try statement and finally statement.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@pmd-test
Copy link

pmd-test commented May 2, 2023 •
edited
Loading

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 10 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report
✅ Compared to master:
This changeset changes 0 violations,
introduces 101 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 13 errors and 0 configuration errors.
Full report

Generated by 🚫 Danger

@adangel adangel added this to the 7.0.0 milestone May 19, 2023
adangel
adangel approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@adangel adangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

adangel added a commit that referenced this pull request May 19, 2023
@adangel
[doc] Update release notes (#4063, #4533)
337d261
adangel added a commit to adangel/pmd that referenced this pull request May 19, 2023
@adangel
Merge pull request pmd#4533 from LynnBroe:issue4063
605dce0 
[java] Fix pmd#4063: False-negative about try/catch block in Loop pmd#4533
@adangel adangel merged commit 3f3216b into pmd:master May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adangel adangel adangel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[java] AvoidBranchingStatementAsLastInLoop: False-negative about try/finally block
3 participants
@LynnBroe @pmd-test @adangel