Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix checkstyle config and checkstyle issues #4923

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix checkstyle config and checkstyle issues #4923

merged 1 commit into from
Apr 4, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Apr 4, 2024

Describe the PR

At some point, I accidentally disabled checkstyle...

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the in:pmd-internals Affects PMD's internals label Apr 4, 2024
@adangel adangel added this to the 7.1.0 milestone Apr 4, 2024
@pmd-test
Copy link

pmd-test commented Apr 4, 2024

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 2 errors and 7 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@jsotuyod jsotuyod merged commit eaec0da into pmd:master Apr 4, 2024
3 checks passed
@adangel adangel deleted the fix-checkstyle-config branch April 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@adangel @pmd-test @jsotuyod