[core] Upgrade saxon to 12.4 #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The rewritten XPaths are slightly different, although equivalent
Generated by 🚫 Danger |
adangel
added
dependencies
adangel
approved these changes
Apr 18, 2024
| @@ -94,13 +107,20 @@ static AxisIterator iterateList(List<? extends NodeInfo> nodes) { | |||
|
|
|||
| @SuppressWarnings({"unchecked", "rawtypes"}) | |||
There was a problem hiding this comment.
Can we remove this suppress warnings now? I see, that we now use generics...
There was a problem hiding this comment.
Hm... we can remove raw types, but still need unchecked
(NodeListIterator requires exactly NodeInfo and not subtypes)
There was a problem hiding this comment.
I'll try something, but in a separate PR...
adangel
added a commit
that referenced
this pull request
Apr 18, 2024
adangel
added a commit
that referenced
this pull request
Apr 18, 2024
Merge pull request #4959 from Monits:upgrade-saxon
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
Saxon currently supports versions 10, 11 and 12. How long version 10 will remain to be supported is not clear, making the upgrade now gives us some future-proofing, while allowing us to benefit from further improvements in Saxon.
All changes are to internal classes, so this is backwards compatible.
Saxon 11+ and 12.1+ support Java 8+, so since PMD 7.0.0 there is no incompatibility on this front either.
Ready?
./mvnw clean verifypasses (checked automatically by github actions)