[core] Typesafe saxon node iterators

[adangel]

Describe the PR

This avoids the unchecked cast, but not sure, whether it's better readable at all.

The other point: Now I'm not extends saxon's ListIterator anymore, which seems to have a lot of optimizations (LastPositionFinder, Lookahead, ...). Maybe that has some performance impact?

So, overall, I'm not sure, whether this change is worth it...

Let's see, whether at least all our XPath rules still work :)

Related issues

• Relates to [core] Upgrade saxon to 12.4 #4959

Ready?

• Added unit tests for fixed bug/feature
• Passing all unit tests
• Complete build ./mvnw clean verify passes (checked automatically by github actions)
• Added (in-code) documentation (if needed)

[pmd-test]

	1 Message
📖	Compared to master: This changeset changes 0 violations, introduces 0 new violations, 0 new errors and 0 new configuration errors, removes 0 violations, 0 errors and 0 configuration errors. Download full report as build artifact
✅	Compared to master: This changeset changes 0 violations, introduces 0 new violations, 0 new errors and 0 new configuration errors, removes 0 violations, 0 errors and 0 configuration errors. Download full report as build artifact

Generated by 🚫 Danger

[oowekyala]

You could use NodeListIterator like before but wrap the nodes list into a Collections.unmodifiableList. That is a type-safe conversion of List<? extends T> to List<T>. I personally would prefer that over rolling our own list iterator implementation.

[adangel]

You could use NodeListIterator like before but wrap the nodes list into a Collections.unmodifiableList. That is a type-safe conversion of List<? extends T> to List<T>. I personally would prefer that over rolling our own list iterator implementation.

Nice trick, this seems to work, thanks!