[core] Expose the full mapping from property type id to property extractor #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. Yes, we probably need this sooner or later. The eclipse plugin might have some support already for defining properties - at least for changing the values of properties. I've updated the eclipse plugin yesterday - the property changes were mostly related to the changed package (so organize import fixed most of the problems). Whatever has been implemented in the eclipse plugin works without this mapping... |
|
I don't remember how it's done in the plugin... maybe it's hardcoded somewhere? Does the plugin support defining properties on XPath rules though? Not just overriding them? If not, I'm not sure it would need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the designer, it occurred to me that we need a way to list the different (type id -> property extractor) mappings, if we want to make a GUI to define properties.