Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[java] Use char notation to represent a character to improve performance #941

Merged
merged 1 commit into from
Mar 3, 2018

Conversation

reudismam
Copy link
Contributor

No description provided.

@jsotuyod jsotuyod self-assigned this Mar 3, 2018
@jsotuyod jsotuyod added this to the 6.2.0 milestone Mar 3, 2018
@jsotuyod jsotuyod changed the title [java] Use char notation to represent a character to improve performance. [java] Use char notation to represent a character to improve performance Mar 3, 2018
@jsotuyod jsotuyod merged commit e1b9542 into pmd:master Mar 3, 2018
jsotuyod added a commit that referenced this pull request Mar 3, 2018
@jsotuyod
Copy link
Member

jsotuyod commented Mar 3, 2018

@reudismam thanks! This will be part of PMD 6.2.0

@lorisdanto
Copy link

@jsotuyod , would you consider adding a rule for this to PMD?

@jsotuyod
Copy link
Member

@lorisdanto we do have an equivalent rule, but it's only using explicit append calls on StringBuilder (javac will convert the + to append at compile time, but PMD won't see it that way).

I'd rather extend that rule for this scenario. Feel free to open an issue, or even better, submit a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants