[java] Make Varargs trigger ArrayIsStoredDirectly #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephengroat amazing! Thanks and congrats on your first contribution! |
|
@jsotuyod kind words and great encouragement for new contributors! a well run project! |
oowekyala
reviewed
Mar 10, 2018
There was a problem hiding this comment.
Nicely done.
I think isArray should return true when isVarargs is true though. If it doesn't, then on varargs parameters, isArray() == false but param.getType().isArray() == true, which could be surprising. That would make one less check for type resolution too. I'd merge this PR as-is and worry about that inconsistency after we merge #912 and #945. There are already too many PRs making changes to this component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a PR, please check that:
master. The PMD team will merge back to support branches as needed.mvn testpasses.mvn checkstyle:checkpasses. Check this for more infoPR Description:
fixes #963