Skip to content
This repository has been archived by the owner on Mar 22, 2023. It is now read-only.

doc: treat doxygen warnings as errors in developer mode #820

Conversation

igchor
Copy link
Contributor

@igchor igchor commented Jul 28, 2020

This change is Reviewable

Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)


doc/CMakeLists.txt, line 2 at r1 (raw file):

# SPDX-License-Identifier: BSD-3-Clause
# Copyright 2018-2019, Intel Corporation

2020

Copy link
Contributor

@KFilipek KFilipek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @igchor)

@igchor igchor force-pushed the treat_doxygen_warnings_as_errors_in_dev_mode branch 2 times, most recently from c762991 to 1ed8d35 Compare July 28, 2020 10:09
Copy link
Member

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@igchor igchor force-pushed the treat_doxygen_warnings_as_errors_in_dev_mode branch from 1ed8d35 to 60af837 Compare July 28, 2020 12:56
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #820 into master will increase coverage by 3.66%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #820      +/-   ##
==========================================
+ Coverage   91.45%   95.11%   +3.66%     
==========================================
  Files          42       42              
  Lines        4470     4918     +448     
==========================================
+ Hits         4088     4678     +590     
+ Misses        382      240     -142     
Flag Coverage Δ
#tests_clang_debug_cpp17 95.14% <ø> (?)
#tests_gcc_debug 91.31% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...j++/container/detail/concurrent_skip_list_impl.hpp 98.03% <ø> (+9.42%) ⬆️
include/libpmemobj++/allocator.hpp 78.12% <0.00%> (-6.50%) ⬇️
include/libpmemobj++/shared_mutex.hpp 80.00% <0.00%> (-5.72%) ⬇️
include/libpmemobj++/make_persistent.hpp 68.42% <0.00%> (-4.00%) ⬇️
include/libpmemobj++/make_persistent_array.hpp 72.88% <0.00%> (-3.21%) ⬇️
include/libpmemobj++/mutex.hpp 86.20% <0.00%> (-2.69%) ⬇️
include/libpmemobj++/condition_variable.hpp 78.57% <0.00%> (-2.51%) ⬇️
include/libpmemobj++/detail/life.hpp 97.87% <0.00%> (-2.13%) ⬇️
include/libpmemobj++/pool.hpp 91.91% <0.00%> (-0.31%) ⬇️
include/libpmemobj++/detail/ctl.hpp 100.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef34801...60af837. Read the comment docs.

@lukaszstolarczuk lukaszstolarczuk merged commit 0e7bb54 into pmem:master Jul 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants