obj: fix a clang warning on our public headers #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llugin: care to check if this works for you? |
|
It works. |
Clang hates them when in C++ mode.
kilobyte
force-pushed
the
clang-anon-union
branch
from
d98f755
to
fe0242e
Compare
Codecov Report
@@ Coverage Diff @@
## stable-1.5 #3501 +/- ##
==============================================
+ Coverage 74.25% 74.27% +0.01%
==============================================
Files 155 155
Lines 26385 26384 -1
==============================================
+ Hits 19592 19596 +4
+ Misses 6793 6788 -5 |
pbalcer
approved these changes
Jan 7, 2019
Greg091
reviewed
Jan 8, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
janekmi
approved these changes
Jan 9, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be fatal with -Werror or in otherwise warning-averse projects.
Ref: pmem/issues#994
This change is