Sync from v4 #300
Merged
Sync from v4 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pmix_server_fencenb_fn_t upcall function cannot return "operation succeeded" as that would prevent the return of any collected data. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit e96d8cb)
Turns out we do need this in the standard Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 9a249a4)
|
I put the WIP label on this because we know of a couple more clarifications coming into v4 that we want to include in this PR once they are finished. So we can hold this PR until we get the latest community clarifications from v4. |
Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 7b9d1a6)
Add reserved prefixes for regular expressions and explain that such prefixes are required to be present. Expand on explanation of refresh cache behavior and required keys. Add new compressed byte object data type. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 39ca7fb)
Per the provided comments Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit e929ed8)
Looks good to me. Signed-off-by: Ralph Castain <rhc@pmix.org> Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com> (cherry picked from commit cc2aa6d)
Signed-off-by: Ralph Castain <rhc@pmix.org> Co-authored-by: Josh Hursey <4259120+jjhursey@users.noreply.github.com> (cherry picked from commit d560896)
|
This PR should bring |
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit b436c5c)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit 440e31b)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit f84a11d)
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com> (cherry picked from commit 2d03624)
Working thru this section and cleaning up based on implementation Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit 9c1e6c4)
|
@rhc54 when you get a chance, can you give this a 👍 so I can bring over the v4 changes to master? Thanks! |
rhc54
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring back
Now master is inline with v4.0rc5
A few more PRs since v4.0rc5