Fix two attribute references. #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `PMIX_LOCALITY` is already in the v4 deprecation list * Only declare `PMIX_SERVER_SCHEDULER` once. Consolidate the definition. * Fixes pmix#264 Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
Ok. I'm done futzing with this. It is ready to go. The first commit addresses the issue with the two attribute declarations. The other commits adjust the "make check" so that it (1) correctly identifies deprecated then removed items, and (2) adds the "make check-decl" to the default checks when someone does a "make". |
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
Signed-off-by: Joshua Hursey <jhursey@us.ibm.com>
|
Ok I fixed the Python3 issues. @rhc54 this is ready for review. |
rhc54
approved these changes
Nov 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMIX_LOCALITYalready marked as deprecated in text.PMIX_SERVER_SCHEDULERonce. Consolidate the definition.