Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add @rspack/core as an optional peer dependency #785

Closed

Conversation

chenjiahan
Copy link

Background

Rspack is a fast Rust-based web bundler and it is compatible with the architecture and ecosystem of webpack.

The react-refresh-webpack-plugin can be used with Rspack, but users will get a peer dependency warning:

 WARN  Issues with peer dependencies found
.
    └─┬ @pmmmwh/react-refresh-webpack-plugin 0.5.10
      └── ✕ missing peer webpack@">=4.43.0 <6.0.0"

Description

This PR adds @rspack/core as an optional peer dependency, and make webpack as an optional peer dependency too.

Related issues

@chenjiahan
Copy link
Author

@pmmmwh Hi, If you have the time, could you review and provide some feedback 😄

@pmmmwh
Copy link
Owner

pmmmwh commented Apr 27, 2024

Hey, sorry that I couldn't give this a proper look previously - if the RSPack team is still interested in this I am willing to land this change in the next version 0.6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants