Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webpack as optional peer dependency #4776

Closed
hardfist opened this issue Mar 17, 2023 · 1 comment · Fixed by #4778
Closed

Add webpack as optional peer dependency #4776

hardfist opened this issue Mar 17, 2023 · 1 comment · Fixed by #4778

Comments

@hardfist
Copy link
Contributor

Feature Proposal

Rspack use webpack-dev-server internally to compatible with devServer functionality but it will cause install warning because lack of webpack. see web-infra-dev/rspack#2318

└─┬ @rspack/cli 0.1.1
  └─┬ @rspack/dev-server 0.1.1
    ├─┬ webpack-dev-server 4.11.1
    │ ├── ✕ missing peer webpack@"^4.37.0 || ^5.0.0"
    │ └─┬ webpack-dev-middleware 5.3.3
    │   └── ✕ missing peer webpack@"^4.0.0 || ^5.0.0"
    └─┬ @rspack/dev-middleware 0.1.1
      └─┬ webpack-dev-middleware 6.0.0
        └── ✕ missing peer webpack@^5.0.0
Peer dependencies that should be installed:
  webpack@">=5.0.0 <6.0.0"

we are wondering whether webpack-dev-server could list webpack as optional peer dependency to help avoid this warning in rspack

Feature Use Case

support use webpack-dev-server in rspack

Please paste the results of npx webpack-cli info here, and mention other relevant information

none

@alexander-akait
Copy link
Member

Because now we have rspack let's do it, previously only webpack can be used, so it don't make sense 😄 , do you want to send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants