Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator rate limits are ineffective when many parallel worlds are used #3974

Open
dktapps opened this issue Dec 17, 2020 · 1 comment
Open
Labels
Category: Core Related to internal functionality Performance Status: Debugged Cause of the bug has been found, but not fixed

Comments

@dktapps
Copy link
Member

dktapps commented Dec 17, 2020

Issue description

It's common particularly in SkyBlock servers for many tens or hundreds of worlds to be loaded simultaneously, since every player often gets their own island.

Generator queues are currently enforced to prevent overloading the async worker pool with generation tasks. However, there is a serious problem with this mechanism: the queue size is limited per world.

This means that players flying around generating terrain independently in several parallel worlds may cause CPU overload regardless. In the case of very compute-expensive or time consuming generators, this can result in serious performance issues without obvious cause (async tasks aren't recorded for timings reports).

OS and versions

  • PocketMine-MP: 3.17.0 / 4.0.0
@dktapps dktapps added Category: Core Related to internal functionality Status: Debugged Cause of the bug has been found, but not fixed Performance labels Dec 17, 2020
@ghost

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Core Related to internal functionality Performance Status: Debugged Cause of the bug has been found, but not fixed
Projects
None yet
Development

No branches or pull requests

1 participant