Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addTitle() buggy (and solution). #823

Closed
Muqsit opened this issue Apr 13, 2017 · 4 comments
Closed

addTitle() buggy (and solution). #823

Muqsit opened this issue Apr 13, 2017 · 4 comments
Labels
Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Resolution: Fixed

Comments

@Muqsit
Copy link
Contributor

Muqsit commented Apr 13, 2017

Issue description

When sending title to player after you've already sent them a title some time ago, the title glitches.
The following could be the result:

  • The subtitle, if set, would still not be shown.
  • The player would receive a previously sent subtitle/title.

Steps to reproduce the issue

  1. Send the player a title with a subtitle using Player::addTitle("", "").
  2. Wait a few seconds.
  3. Send the player another title with a subtitle (make the text different from the first one to spot differences).
  4. Watch how they glitch.

OS and versions

  • PocketMine-MP: 7c66af5
  • PHP: 7.0.17
  • Server OS: Ubuntu 14.04 64-bit
  • Game version: Win10

Crashdump, backtrace or other files

-=-

@moskadev
Copy link
Contributor

Thanks Max x)

@dktapps
Copy link
Member

dktapps commented Apr 13, 2017

Please create a pull request if you know how to fix the issue.

@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Category: API Related to the plugin API Status: Debugged Cause of the bug has been found, but not fixed labels Apr 13, 2017
@Muqsit Muqsit closed this as completed Apr 13, 2017
@Muqsit Muqsit reopened this Apr 13, 2017
@Muqsit
Copy link
Contributor Author

Muqsit commented Apr 14, 2017

This has been fixed in api3/network. Closing..

@Muqsit Muqsit closed this as completed Apr 14, 2017
@dktapps dktapps added Resolution: Fixed and removed Status: Debugged Cause of the bug has been found, but not fixed labels Apr 14, 2017
@dktapps
Copy link
Member

dktapps commented Apr 14, 2017

I meant to squash-merge that PR, but my browser was acting up. There are two commits on the branch head, yours (319763d) and the merge commit (40775f5).

inxomnyaa pushed a commit to ClearSkyTeam/PocketMine-MP that referenced this issue Apr 26, 2017
Thanks to @SuperMaXAleX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Related to the plugin API Category: Gameplay Related to Minecraft gameplay experience Resolution: Fixed
Projects
None yet
Development

No branches or pull requests

3 participants