Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setBlock does not create/remove tiles #880

Closed
inxomnyaa opened this issue May 2, 2017 · 5 comments
Closed

setBlock does not create/remove tiles #880

inxomnyaa opened this issue May 2, 2017 · 5 comments
Labels
Category: API Related to the plugin API Category: Core Related to internal functionality Resolution: Fixed
Milestone

Comments

@inxomnyaa
Copy link
Contributor

inxomnyaa commented May 2, 2017

Issue description

For several reasons i've experienced plugin using setBlock, but forgetting to create/remove a tile for e.g. chests.
So, there are invisible tile blocks after a rejoin, which can be quite annoying

The other scenario: A plugin uses setblock, but doesn't remove the tile. when another tile is placed at the same position, it contains the same data as the old one.
For example you can setBlock a monsterspawner where a chest was, and then you hav a chest displayed inside a monster spawner.

Giving the server the option to remove this would also reduce some load (ticked tiles) and memory on levels, and Level::getTiles() would no longer return invalid tiles.

When setting a TileBlock, a tile could be created using the default compound (previousely getSpawnCompound)

Steps to reproduce the issue

  1. setblock a chest
  2. ur setblock air where a chest was

OS and versions

@dktapps dktapps added Category: Core Related to internal functionality Status: Debugged Cause of the bug has been found, but not fixed labels May 2, 2017
@robske110
Copy link
Contributor

btw you can't link a static artifact name on lastSuccessfulBuild @thebigsmileXD

@inxomnyaa
Copy link
Contributor Author

inxomnyaa commented May 4, 2017

Why not, the vrsion is fully stated behind it.
image

@dktapps dktapps added the Category: API Related to the plugin API label May 10, 2017
@inxomnyaa
Copy link
Contributor Author

Bump: Is this actually a TODO, or should users better create tiles themself via the new, easier tile function?

@dktapps
Copy link
Member

dktapps commented Oct 24, 2017

ideally plugin developers shouldn't need to know that "tiles" or "block entities" are even a thing - they should just be blocks with special behaviour. So yes, this is a TODO.

@dktapps
Copy link
Member

dktapps commented Oct 30, 2018

This is planned for resolution in 4.0. Work is underway to deal with this, amongst other issues.

@dktapps dktapps added this to the 4.0 milestone Oct 30, 2018
@dktapps dktapps added Resolution: Fixed and removed Status: Debugged Cause of the bug has been found, but not fixed Type: To Do labels Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: API Related to the plugin API Category: Core Related to internal functionality Resolution: Fixed
Projects
None yet
Development

No branches or pull requests

3 participants