Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1551 Slowness Effect levels >= 7 do not reset FOV when removed #2342

Closed
wants to merge 4 commits into from
Closed

fix #1551 Slowness Effect levels >= 7 do not reset FOV when removed #2342

wants to merge 4 commits into from

Conversation

djdisodo
Copy link
Contributor

slowness always has higher priority than speed

tested

if this code has problem
blame my little bro !!!!!!!!!!!!!!!plz
@djdisodo
Copy link
Contributor Author

#1551

@dktapps
Copy link
Member

dktapps commented Jul 29, 2018

If it was this simple it would have been done already. This is just a hack and will break things such as overlapping speed and slowness effects.

As I wrote in the issue, this requires an attribute modifier implementation.

Please also read the contribution guidelines, particularly the part that says avoid the web editor.

@dktapps dktapps closed this Jul 29, 2018
@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Type: Fix Bug fix, typo fix, or any other fix Resolution: Declined PR has been declined by maintainers labels Jul 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Gameplay Related to Minecraft gameplay experience Resolution: Declined PR has been declined by maintainers Type: Fix Bug fix, typo fix, or any other fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants