Player: remove move buffering, implement simple rate limited movement… #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
added
BC break
|
Wow |
|
Considering the high value of the changes in this PR, I've decided to try and make this backwards compatible. |
… processing this needs some work to fix move sync spam in some areas, but this is nothing that wasn't already a problem to begin with.
dktapps
force-pushed
the
experimental/better-movement
branch
from
8e43cce
to
4ed444d
Compare
|
never mind, seems like I can't hack this perfectly... so, it's time to bend the rules a little bit. |
dktapps
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… processing
this needs some work to fix move sync spam in some areas, but this is nothing that wasn't already a problem to begin with.
Introduction
This PR is a second attempt at improving movement processing to fix #1215 , #2730 and more.
This is significantly less complex than the previous attempt #2646 -- it gets rid of the movement buffering system entirely and instead relies on a simple rate limit counter to restrict on-the-fly movement processing.
Movement is rate limited to a max average of 2 per tick. It allows up to 5 seconds' backlog to accommodate network lag. The rate limit counter is increased by 2 per tick and decreased once for every movement processed. This prevents movement processing being abused for denial of service attacks.
Changes
API changes
This PR, while obviously highly beneficial for most current users, poses some BC-breaking issues because of changes to the internal Player API.
Player->processMovement()(protected) has been removed. This is a BC concern for custom player classes which overrode it and called it as a parent. In addition, child implementations won't be called every tick any more, which could break some custom movement processing systems.Player->newPosition(protected) has been removed. This internal field may have been accessed by custom movement implementations.Player->isTeleporting(protected) has been removed. BC concern is same as previous point.Player->getNextPosition()(public) has been@deprecated.Playerclass members:int $moveRateLimit?Vector3 $forceMoveSynchandleMovement()processMostRecentMovements()revertMovement()Behavioural changes
Player movement is now subject to less rubberbanding and has more reliable behaviour.
Tests
Basic testing has been done. There are some corner cases which I'm not completely happy with yet, but those are equivalent to problems which already existed.