-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalize asynchronous events #6092
Open
ShockedPlot7560
wants to merge
24
commits into
minor-next
Choose a base branch
from
feat/async-events
base: minor-next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Oct 14, 2023
-
code came from #6015 and will be subject to probable changes
Configuration menu - View commit details
-
Copy full SHA for 5fe57a8 - Browse repository at this point
Copy the full SHA 5fe57a8View commit details -
introduce AsyncEvent and ::callAsync()
An asynchronous event is one that allows the addition of promises to be resolved before being completed. This implementation integrates priority levels, allowing you to wait for all promises added to one level before moving on to the next. This is made possible by separating the event call logic into several functions, which can then be integrated into AsyncEventTrait::callAsync()
Configuration menu - View commit details
-
Copy full SHA for a84fc2b - Browse repository at this point
Copy the full SHA a84fc2bView commit details
Commits on Oct 22, 2023
-
events: asynchandler is defined by their return type and event type
If the event is async and the handler return Promise, it will be handle as an async event. However, if the event is async and the handler return smth different than Promise, it will be handle synchronously. An async handler can specify if it wishes to be called with no concurrent handlers with the tag @noConcurrentCall
Configuration menu - View commit details
-
Copy full SHA for 7a4b9a0 - Browse repository at this point
Copy the full SHA 7a4b9a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b2b92a - Browse repository at this point
Copy the full SHA 9b2b92aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b78ff00 - Browse repository at this point
Copy the full SHA b78ff00View commit details -
Configuration menu - View commit details
-
Copy full SHA for c250bb0 - Browse repository at this point
Copy the full SHA c250bb0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 58155a7 - Browse repository at this point
Copy the full SHA 58155a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b2fa9d - Browse repository at this point
Copy the full SHA 2b2fa9dView commit details
Commits on Oct 23, 2023
-
Co-authored-by: Javier León <58715544+JavierLeon9966@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 1176b70 - Browse repository at this point
Copy the full SHA 1176b70View commit details
Commits on Oct 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dc85bba - Browse repository at this point
Copy the full SHA dc85bbaView commit details -
cannot call async event in sync context + remove Event dependency for…
… AsyncEventDelegate
Configuration menu - View commit details
-
Copy full SHA for ed739cf - Browse repository at this point
Copy the full SHA ed739cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e87fbb - Browse repository at this point
Copy the full SHA 7e87fbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5beaa3c - Browse repository at this point
Copy the full SHA 5beaa3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc6e8ef - Browse repository at this point
Copy the full SHA cc6e8efView commit details -
Configuration menu - View commit details
-
Copy full SHA for ca95b2f - Browse repository at this point
Copy the full SHA ca95b2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 823d4ea - Browse repository at this point
Copy the full SHA 823d4eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 243a303 - Browse repository at this point
Copy the full SHA 243a303View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaa37ba - Browse repository at this point
Copy the full SHA aaa37baView commit details
Commits on Jan 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f82c422 - Browse repository at this point
Copy the full SHA f82c422View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64bbff6 - Browse repository at this point
Copy the full SHA 64bbff6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6b7a9e - Browse repository at this point
Copy the full SHA d6b7a9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for eb98141 - Browse repository at this point
Copy the full SHA eb98141View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1e3903 - Browse repository at this point
Copy the full SHA c1e3903View commit details
Commits on Jul 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b276133 - Browse repository at this point
Copy the full SHA b276133View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.