Add Structure void #6156
Open
Add Structure void #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bqleine
force-pushed
the
structure-void
branch
from
a545a54
to
3b37327
Compare
dktapps
reviewed
Nov 14, 2023
dktapps
reviewed
Nov 14, 2023
dktapps
reviewed
Nov 16, 2023
dktapps
reviewed
Nov 16, 2023
src/data/bedrock/block/convert/BlockStateToObjectDeserializer.php
Outdated
Show resolved
Hide resolved
dktapps
reviewed
Nov 16, 2023
src/data/bedrock/block/convert/BlockObjectToStateSerializer.php
Outdated
Show resolved
Hide resolved
dktapps
reviewed
Nov 16, 2023
There was a problem hiding this comment.
The PR looks mostly fine. Since we don't have any structure blocks, the difference between structure void and structure air is not important for now, though I would like to know the differences in the future.
There are some minor nits that need to be addressed.
dktapps
added
Category: Gameplay
Bqleine
force-pushed
the
structure-void
branch
from
e92c6d7
to
71dc036
Compare
dktapps
reviewed
Dec 20, 2023
src/block/StructureVoid.php
Outdated
| $w->enum($this->type); | ||
| } | ||
|
|
||
| public function getType() : StructureVoidType{ |
There was a problem hiding this comment.
getType() is not generally used because it's too ambiguous
getStructureVoidType() would be better
There was a problem hiding this comment.
Should setType() also be renamed to setStructureVoidType()?
|
Thank you very much @pandaa-be :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This pull request is extracted from #6045. It adds the structure void block, along with it's air variant.
Relevant issues
Changes
This is a non-disruptive addition of blocks.
Follow-up
The card linked above should be updated to done.
Tests
/give <player> structure_void