-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation with Typedoc again #54
Conversation
840709a
to
a29c094
Compare
Hey @marcofugaro, I can help out with this in my spare time, and push AABB unless you had other plans. :) |
❤️❤️ Basically here is what you do:
In the meantime I was working on updating the examples to three 0.125 and researching a better way of doing the BufferGeometry to ConvexGeometry conversion in the branch |
@marcofugaro Yeah - I saw b1ff14a - it's very helpful. :) I completely missed the r125 branch; I guess the pull to fix use-cannon can wait on whatever we settle on as I quite like being able to simply pass geometries to convexPolyhedron. |
🤩 amazing work @stockhuman thanks a lot! Just an issue, could you leave out of this PR the stuff non related to JSDoc? Such as using an inline This is the diff of the stuff you did, if it's useful b1ff14a...pmndrs:0b81356 |
Sure thing, will undo. :) |
Thanks for the amazing work @stockhuman!! I'll take it from here, fix the build issue and solve conflicts in next few days. |
Awesome, glad I could help. :) |
Note, Ray may need more work
Additional documentation added with references to the paper Cannon is based on
Excluding WheelInfo -> seems not to be documenting properly?
The documentation is done! 🎉 Preview: https://raw.githack.com/pmndrs/cannon-es/typedoc2/docs/index.html Ended up enabling the Only thing to fix is the build issue, it's pretty straightforward, will fix it soon. |
Close #12
This PR is a continuation of #14, it uses the newer beta of Typedoc being developed in TypeStrong/typedoc#1364.
Preview of the docs here
Things to fix
Currently the class params are not being shown,
this is probably because the JSDoc @param definition is not supported in Typedoc
However they are being shown in the homepage, which is not the correct place for them
I guess this is because the type
BodyOptions
is exported directly?This is because the comment are currently in line format:
![](https://user-images.githubusercontent.com/7217420/99292248-41642700-2841-11eb-87e9-226b3d73d56f.png)
![](https://user-images.githubusercontent.com/7217420/99292311-5476f700-2841-11eb-8a9e-a078fad82d5a.png)
They need to be in JSDoc format:
UI/UX Improvements
All
andOnly exported
keys, we don't use them in this project