Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export OrbitControls from another lib in native #1836

Open
TiagoCavalcante opened this issue Feb 17, 2024 · 3 comments
Open

Export OrbitControls from another lib in native #1836

TiagoCavalcante opened this issue Feb 17, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@TiagoCavalcante
Copy link
Contributor

Hi, I'm the developer of r3f-native-orbitcontrols, which has almost 30k downloads in NPM now.

The current version of drei's OrbitControls doesn't work in React Native, so I suggest exporting the orbit controls from my library, which works in native (but not on the web though).

@TiagoCavalcante TiagoCavalcante added the enhancement New feature or request label Feb 17, 2024
@CodyJasonBennett
Copy link
Member

This is a breaking change in Drei WRT API, so I'd prefer to do so only as a last resort, and/or amortize with the next major release. I see a publishing issue in your library which I'll address momentarily there.

I think I'd much rather implement the basic EventEmitter interface for examples/jsm controls to work, which is a little more complicated than pmndrs/react-three-fiber#3173 since they access document and element-document references for focus states. Not mentioned there, but there is a regression since we switched to gestures where the R3F canvas isn't compatible with your controls since it overrides gesture props instead of joining them into separate callbacks; fix is as described upstream.

@TiagoCavalcante
Copy link
Contributor Author

This is a breaking change in Drei WRT API, so I'd prefer to do so only as a last resort, and/or amortize with the next major release. I see a publishing issue in your library which I'll address momentarily there.

I think I'd much rather implement the basic EventEmitter interface for examples/jsm controls to work, which is a little more complicated than pmndrs/react-three-fiber#3173 since they access document and element-document references for focus states.

Makes sense.

Not mentioned there, but there is a regression since we switched to gestures where the R3F canvas isn't compatible with your controls since it overrides gesture props instead of joining them into separate callbacks;

Which gestures aren't working?

fix is as described upstream.

I didn't understand in which repository the fix was described.

@CodyJasonBennett
Copy link
Member

In R3F we'll need fixes so you can spread GestureResponder props over Canvas. Looking into it already, but I believe we or someone using your library found this in our Discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants