Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): does not throw with an empty list to waitForAll #1181

Merged
merged 17 commits into from
Jun 2, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented May 24, 2022

close #1177

@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Jun 2, 2022 at 2:36AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 24, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d70c0bd:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration
React Typescript (forked) Issue #1177

@github-actions
Copy link

github-actions bot commented May 24, 2022

Size Change: +128 B (0%)

Total Size: 145 kB

Filename Size Change
dist/esm/utils.js 5.15 kB +24 B (0%)
dist/system/utils.development.js 5.49 kB +25 B (0%)
dist/system/utils.production.js 3.53 kB +14 B (0%)
dist/umd/utils.development.js 9.61 kB +29 B (0%)
dist/umd/utils.production.js 6.18 kB +9 B (0%)
dist/utils.js 9.4 kB +27 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 881 B
dist/babel/plugin-react-refresh.js 1.1 kB
dist/babel/preset.js 1.33 kB
dist/devtools.js 3.85 kB
dist/esm/babel/plugin-debug-label.js 711 B
dist/esm/babel/plugin-react-refresh.js 924 B
dist/esm/babel/preset.js 1.15 kB
dist/esm/devtools.js 3.18 kB
dist/esm/immer.js 609 B
dist/esm/index.js 5.08 kB
dist/esm/optics.js 661 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.53 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 1.13 kB
dist/esm/zustand.js 284 B
dist/immer.js 726 B
dist/index.js 5.92 kB
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/system/babel/plugin-debug-label.development.js 818 B
dist/system/babel/plugin-debug-label.production.js 618 B
dist/system/babel/plugin-react-refresh.development.js 1.02 kB
dist/system/babel/plugin-react-refresh.production.js 798 B
dist/system/babel/preset.development.js 1.25 kB
dist/system/babel/preset.production.js 990 B
dist/system/devtools.development.js 3.36 kB
dist/system/devtools.production.js 2.41 kB
dist/system/immer.development.js 733 B
dist/system/immer.production.js 469 B
dist/system/index.development.js 5.3 kB
dist/system/index.production.js 3.06 kB
dist/system/optics.development.js 765 B
dist/system/optics.production.js 455 B
dist/system/query.development.js 1.4 kB
dist/system/query.production.js 963 B
dist/system/redux.development.js 339 B
dist/system/redux.production.js 217 B
dist/system/urql.development.js 1.68 kB
dist/system/urql.production.js 1.18 kB
dist/system/valtio.development.js 639 B
dist/system/valtio.production.js 400 B
dist/system/xstate.development.js 1.25 kB
dist/system/xstate.production.js 805 B
dist/system/zustand.development.js 372 B
dist/system/zustand.production.js 235 B
dist/umd/babel/plugin-debug-label.development.js 1.03 kB
dist/umd/babel/plugin-debug-label.production.js 776 B
dist/umd/babel/plugin-react-refresh.development.js 1.24 kB
dist/umd/babel/plugin-react-refresh.production.js 931 B
dist/umd/babel/preset.development.js 1.47 kB
dist/umd/babel/preset.production.js 1.12 kB
dist/umd/devtools.development.js 3.98 kB
dist/umd/devtools.production.js 2.69 kB
dist/umd/immer.development.js 871 B
dist/umd/immer.production.js 570 B
dist/umd/index.development.js 6.02 kB
dist/umd/index.production.js 3.31 kB
dist/umd/optics.development.js 1.08 kB
dist/umd/optics.production.js 671 B
dist/umd/query.development.js 1.5 kB
dist/umd/query.production.js 1.03 kB
dist/umd/redux.development.js 454 B
dist/umd/redux.production.js 322 B
dist/umd/urql.development.js 1.77 kB
dist/umd/urql.production.js 1.22 kB
dist/umd/valtio.development.js 722 B
dist/umd/valtio.production.js 500 B
dist/umd/xstate.development.js 1.34 kB
dist/umd/xstate.production.js 852 B
dist/umd/zustand.development.js 479 B
dist/umd/zustand.production.js 334 B
dist/urql.js 1.62 kB
dist/valtio.js 586 B
dist/xstate.js 1.19 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi
Copy link
Member Author

dai-shi commented May 24, 2022

@dai-shi
Copy link
Member Author

dai-shi commented May 24, 2022

The change causes jest errors with react 17. Can anybody know how to workaround this?

@dai-shi dai-shi marked this pull request as ready for review June 2, 2022 02:40
@dai-shi dai-shi added this to the v1.7.1 milestone Jun 2, 2022
@dai-shi dai-shi merged commit 036aed3 into main Jun 2, 2022
@dai-shi dai-shi deleted the fix/issue-1177 branch June 2, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

waitForAll throws with an empty list
1 participant