Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix doc example in loadable api #1446

Merged
merged 1 commit into from Sep 25, 2022

Conversation

masashi-sutou
Copy link
Contributor

@masashi-sutou masashi-sutou commented Sep 25, 2022

Related Issues

  • none

Summary

  • Fixed how variables are assigned when getting an asynchronous response using the loadable API in the sample docs.
  • Since the response type is [Awaited<Value>, never], we need to enclose the variable in square brackets. Or is it better to fix it with useAtomValue?

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Sep 25, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Sep 25, 2022 at 5:46AM (UTC)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 884c99f:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dai-shi dai-shi merged commit d16b49c into pmndrs:main Sep 25, 2022
@masashi-sutou masashi-sutou deleted the chore/typo_docs branch September 25, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants