Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vanilla): simplify store impl (v2 API) #1624

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 8, 2022

follow up #1611.
I forgot something is no longer used, so removed.

@vercel
Copy link

vercel bot commented Dec 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
jotai ✅ Ready (Inspect) Visit Preview Dec 8, 2022 at 0:03AM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 8, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a2e8fe5:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Size Change: -99 B (0%)

Total Size: 201 kB

Filename Size Change
dist/esm/vanilla.js 2.81 kB -17 B (-1%)
dist/system/vanilla.development.js 2.9 kB -17 B (-1%)
dist/system/vanilla.production.js 1.63 kB -6 B (0%)
dist/umd/vanilla.development.js 3.82 kB -24 B (-1%)
dist/umd/vanilla.production.js 2.24 kB -11 B (0%)
dist/vanilla.js 3.73 kB -24 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 876 B
dist/babel/plugin-react-refresh.js 1.11 kB
dist/babel/preset.js 1.35 kB
dist/devtools.js 3.79 kB
dist/esm/babel/plugin-debug-label.js 869 B
dist/esm/babel/plugin-react-refresh.js 1.05 kB
dist/esm/babel/preset.js 1.32 kB
dist/esm/devtools.js 2.97 kB
dist/esm/immer.js 77 B
dist/esm/index.js 5.2 kB
dist/esm/optics.js 60 B
dist/esm/query.js 442 B
dist/esm/react.js 965 B
dist/esm/react/devtools.js 2.46 kB
dist/esm/react/utils.js 574 B
dist/esm/redux.js 65 B
dist/esm/urql.js 776 B
dist/esm/utils.js 5.26 kB
dist/esm/valtio.js 66 B
dist/esm/vanilla/utils.js 3.89 kB
dist/esm/xstate.js 77 B
dist/esm/zustand.js 67 B
dist/immer.js 186 B
dist/index.js 6.14 kB
dist/optics.js 159 B
dist/query.js 698 B
dist/react.js 1.06 kB
dist/react/devtools.js 3.24 kB
dist/react/utils.js 1.25 kB
dist/redux.js 161 B
dist/system/babel/plugin-debug-label.development.js 970 B
dist/system/babel/plugin-debug-label.production.js 728 B
dist/system/babel/plugin-react-refresh.development.js 1.15 kB
dist/system/babel/plugin-react-refresh.production.js 899 B
dist/system/babel/preset.development.js 1.42 kB
dist/system/babel/preset.production.js 1.1 kB
dist/system/devtools.development.js 3.16 kB
dist/system/devtools.production.js 2.11 kB
dist/system/immer.development.js 185 B
dist/system/immer.production.js 150 B
dist/system/index.development.js 5.43 kB
dist/system/index.production.js 3.02 kB
dist/system/optics.development.js 164 B
dist/system/optics.production.js 129 B
dist/system/query.development.js 567 B
dist/system/query.production.js 385 B
dist/system/react.development.js 1.13 kB
dist/system/react.production.js 714 B
dist/system/react/devtools.development.js 2.63 kB
dist/system/react/devtools.production.js 1.83 kB
dist/system/react/utils.development.js 720 B
dist/system/react/utils.production.js 451 B
dist/system/redux.development.js 167 B
dist/system/redux.production.js 132 B
dist/system/urql.development.js 919 B
dist/system/urql.production.js 605 B
dist/system/utils.development.js 5.64 kB
dist/system/utils.production.js 3.55 kB
dist/system/valtio.development.js 169 B
dist/system/valtio.production.js 134 B
dist/system/vanilla/utils.development.js 4.12 kB
dist/system/vanilla/utils.production.js 2.6 kB
dist/system/xstate.development.js 184 B
dist/system/xstate.production.js 149 B
dist/system/zustand.development.js 168 B
dist/system/zustand.production.js 134 B
dist/umd/babel/plugin-debug-label.development.js 1.04 kB
dist/umd/babel/plugin-debug-label.production.js 819 B
dist/umd/babel/plugin-react-refresh.development.js 1.26 kB
dist/umd/babel/plugin-react-refresh.production.js 985 B
dist/umd/babel/preset.development.js 1.49 kB
dist/umd/babel/preset.production.js 1.21 kB
dist/umd/devtools.development.js 3.92 kB
dist/umd/devtools.production.js 2.6 kB
dist/umd/immer.development.js 329 B
dist/umd/immer.production.js 275 B
dist/umd/index.development.js 6.25 kB
dist/umd/index.production.js 3.47 kB
dist/umd/optics.development.js 300 B
dist/umd/optics.production.js 249 B
dist/umd/query.development.js 838 B
dist/umd/query.production.js 585 B
dist/umd/react.development.js 1.19 kB
dist/umd/react.production.js 805 B
dist/umd/react/devtools.development.js 3.37 kB
dist/umd/react/devtools.production.js 2.36 kB
dist/umd/react/utils.development.js 1.41 kB
dist/umd/react/utils.production.js 1.01 kB
dist/umd/redux.development.js 304 B
dist/umd/redux.production.js 252 B
dist/umd/urql.development.js 4.64 kB
dist/umd/urql.production.js 3.23 kB
dist/umd/utils.development.js 9.91 kB
dist/umd/utils.production.js 6.41 kB
dist/umd/valtio.development.js 303 B
dist/umd/valtio.production.js 252 B
dist/umd/vanilla/utils.development.js 4.84 kB
dist/umd/vanilla/utils.production.js 3.04 kB
dist/umd/xstate.development.js 327 B
dist/umd/xstate.production.js 273 B
dist/umd/zustand.development.js 306 B
dist/umd/zustand.production.js 253 B
dist/urql.js 4.46 kB
dist/utils.js 9.68 kB
dist/valtio.js 162 B
dist/vanilla/utils.js 4.68 kB
dist/xstate.js 184 B
dist/zustand.js 164 B

compressed-size-action

@dai-shi dai-shi added this to the v1.11.2 milestone Dec 8, 2022
@dai-shi dai-shi merged commit 5a620db into main Dec 12, 2022
@dai-shi dai-shi deleted the refactor/vanilla/simplify-store-impl branch December 12, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant