Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(test): Implement skipIf for conditional test skipping #2161

Merged
merged 2 commits into from Oct 2, 2023

Conversation

NaamuKim
Copy link
Contributor

@NaamuKim NaamuKim commented Oct 2, 2023

Related Issues or Discussions

zustand react 18 ssr test PR

Summary

Use skipIf to conditionally skip tests based on the availability of useTransition and use features, enhancing test suite maintainability and readability.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 0:51am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit cf6ee56:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

Use skipIf to conditionally skip tests based on the availability of useTransition and use features, enhancing test suite maintainability and readability.
@NaamuKim NaamuKim changed the title refactor(tests): Implement skipIf for conditional test skipping refactor(test): Implement skipIf for conditional test skipping Oct 2, 2023
Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement!

tests/react/transition.test.tsx Show resolved Hide resolved
@dai-shi dai-shi merged commit 56287a1 into pmndrs:main Oct 2, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants