fix(utils): improve freezeAtom and freezeAtomCreator #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/7PSU5JVSZ |
See documentations for usage instructions.
dai-shi
reviewed
Apr 2, 2024
|
Thanks for the catch. Can you also fix it? |
backbone87
force-pushed
the
freeze-atom-failing-test-case
branch
from
de9a2ae
to
e954636
Compare
|
added a fix and expanded the test case to check for deep freeze. also applied the same strategy that is used in freezeAtomCreator to |
dai-shi
approved these changes
Apr 7, 2024
dai-shi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
None
Summary
Extends the
freezeAtomCreatortest to unveil a bugCheck List
yarn run prettierfor formatting code and docs