Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gatsby Link URL partial match. #2520

Merged
merged 25 commits into from
May 1, 2024
Merged

Fix Gatsby Link URL partial match. #2520

merged 25 commits into from
May 1, 2024

Conversation

ouweiya
Copy link
Contributor

@ouweiya ouweiya commented Apr 25, 2024

When multiple path URLs are partially the same, it can cause simultaneous highlighting.

chrome_zqEPBcj8Kr

Fix 'key' prop error

Warning: Each child in a list should have a unique "key" prop.

The 'introduction' section has no parent directory, section.title is undefined.

When the title is inline code, the ID is undefined
When the title is inline code, value is a React element, returning an empty string will cause the ID to be unavailable, making the anchor point invalid.

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2024 7:51am

Copy link

codesandbox-ci bot commented Apr 25, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Apr 25, 2024

LiveCodes Preview in LiveCodes

Latest commit: 7421a6e
Last updated: Apr 30, 2024 7:50am (UTC)

Playground Link
React demo https://livecodes.io?x=id/HBXY3VG8Z

See documentations for usage instructions.

Copy link
Collaborator

@sandren sandren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ouweiya Thanks for these fixes!

Could you please run Prettier and also revert the changes to performance.mdx in bfb555b? Let's move the more substantive revisions to the docs into a separate PR. Thanks. 🙂

@sandren
Copy link
Collaborator

sandren commented May 1, 2024

Thanks! 🙂

@sandren sandren merged commit a4bb527 into pmndrs:main May 1, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants