Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(imports): update the imports declarations of type annotations and declarations to import type #606

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

liby
Copy link
Contributor

@liby liby commented Jul 20, 2021

@vercel
Copy link

vercel bot commented Jul 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/FRyxyWfEzW433iqM1LFQd4FrPdrB
✅ Preview: https://jotai-git-fork-liby-master-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e36c08:

Sandbox Source
React Configuration
React Typescript Configuration

@dai-shi
Copy link
Member

dai-shi commented Jul 20, 2021

is this really necessary?

This would be just a preference, but it helps to me to understand dependencies across bundles. So, it might not be really necessary, but make things consistent.

@dai-shi
Copy link
Member

dai-shi commented Jul 20, 2021

I also confirmed, tsconfig change doesn't affect bundles.

$ git diff tsconfig.json
diff --git a/tsconfig.json b/tsconfig.json
index 9f5dd48..3f3d107 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -2,7 +2,7 @@
   "compilerOptions": {
     "target": "es2019",
     "strict": true,
-    "jsx": "preserve",
+    "jsx": "react-jsx",
     "allowSyntheticDefaultImports": true,
     "esModuleInterop": true,
     "moduleResolution": "node",
$ diff -r dist.jsx_preserve dist.jsx_react-jsx
$ 

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work. Much appreciated.
Yeah, it's not 100% certain if we can continue the style in the future.
For now, it looks good to me. (examples may not work with old TS, but let's hope no one complain.)

@dai-shi dai-shi merged commit afa0a34 into pmndrs:master Jul 20, 2021
@liby
Copy link
Contributor Author

liby commented Jul 20, 2021

This would be just a preference, but it helps to me to understand dependencies across bundles. So, it might not be really necessary, but make things consistent.

I see what you mean.

Thanks for the work. Much appreciated.

That's alright, glad to help!

For now, it looks good to me. (examples may not work with old TS, but let's hope no one complain.)

If there are any problems in the future, let's communicate at that time to see how to modify them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants