Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): unstable_promise option in write getter #855

Merged
merged 1 commit into from
Nov 29, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Nov 29, 2021

This experimental feature is first introduced in #539.
We don't get much feedback, and it's still experimental.
But, we hope to make it stable in the future. For now, this makes it an option object and no longer warns.

@vercel
Copy link

vercel bot commented Nov 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/4L4WGqbZ1LzeFyCfFCp6NZZATneD
✅ Preview: https://jotai-git-fix-unstable-promise-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f19c65b:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

Size Change: +23 B (0%)

Total Size: 40.7 kB

Filename Size Change
dist/esm/index.js 4.3 kB +8 B (0%)
dist/index.js 5.17 kB +15 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/plugin-react-refresh.js 947 B
dist/babel/preset.js 1.21 kB
dist/devtools.js 1.73 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/plugin-react-refresh.js 763 B
dist/esm/babel/preset.js 1.01 kB
dist/esm/devtools.js 1.57 kB
dist/esm/immer.js 597 B
dist/esm/optics.js 644 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.44 kB
dist/esm/utils.js 4.35 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 1.13 kB
dist/esm/zustand.js 284 B
dist/immer.js 732 B
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/urql.js 1.49 kB
dist/utils.js 5.22 kB
dist/valtio.js 586 B
dist/xstate.js 1.19 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi merged commit c6d0a80 into main Nov 29, 2021
@dai-shi dai-shi deleted the fix/unstable-promise branch November 29, 2021 15:50
@dai-shi dai-shi added this to the v1.4.6 milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant