Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): refactor internal state listener #914

Merged
merged 2 commits into from
Dec 29, 2021
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 29, 2021

This is just a refactor of an internal DEV-only function. When we refactored with DEV_GET_MOUNTED_ATOMS, we no longer need to notify each updating state, and it's cleaner and should behave better.

@dai-shi dai-shi added this to the v1.5.0 milestone Dec 29, 2021
@vercel
Copy link

vercel bot commented Dec 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/DHsNLC4cpf9dzyydD9DHcYkLxdE7
✅ Preview: https://jotai-git-fix-corestate-listener-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 29, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f205374:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

github-actions bot commented Dec 29, 2021

Size Change: -81 B (0%)

Total Size: 43.3 kB

Filename Size Change
dist/devtools.js 1.69 kB -47 B (-3%)
dist/esm/devtools.js 1.55 kB -45 B (-3%)
dist/esm/index.js 5.18 kB +8 B (0%)
dist/index.js 5.96 kB +3 B (0%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/plugin-react-refresh.js 947 B
dist/babel/preset.js 1.21 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/plugin-react-refresh.js 763 B
dist/esm/babel/preset.js 1.01 kB
dist/esm/immer.js 616 B
dist/esm/optics.js 661 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.49 kB
dist/esm/utils.js 4.55 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 1.13 kB
dist/esm/zustand.js 284 B
dist/immer.js 732 B
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/urql.js 1.54 kB
dist/utils.js 5.79 kB
dist/valtio.js 586 B
dist/xstate.js 1.19 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi merged commit 9c29f57 into main Dec 29, 2021
@dai-shi dai-shi deleted the fix/core/state-listener branch December 29, 2021 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant