Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): refactor with createReadDependencies #916

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Dec 30, 2021

  • Refactor code for a little more readability
  • createReadDependencies not to return a new reference if the content is the same
  • handle edge cases in versioned write for feat(devtools): useAtomsDevtools #837 (very hacky for now)

@dai-shi dai-shi added this to the v1.5.0 milestone Dec 30, 2021
@vercel
Copy link

vercel bot commented Dec 30, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/jotai/57GAt5bRp7bUgQsWgk6a4JDGCLJN
✅ Preview: https://jotai-git-fix-corerefactor-versioned-write-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 569f147:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
Next.js Configuration
Next.js with custom Babel config Configuration
React with custom Babel config Configuration

@github-actions
Copy link

Size Change: +163 B (0%)

Total Size: 43.4 kB

Filename Size Change
dist/esm/index.js 5.26 kB +83 B (+2%)
dist/index.js 6.04 kB +80 B (+1%)
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 794 B
dist/babel/plugin-react-refresh.js 947 B
dist/babel/preset.js 1.21 kB
dist/devtools.js 1.69 kB
dist/esm/babel/plugin-debug-label.js 622 B
dist/esm/babel/plugin-react-refresh.js 763 B
dist/esm/babel/preset.js 1.01 kB
dist/esm/devtools.js 1.55 kB
dist/esm/immer.js 616 B
dist/esm/optics.js 661 B
dist/esm/query.js 1.25 kB
dist/esm/redux.js 251 B
dist/esm/urql.js 1.49 kB
dist/esm/utils.js 4.55 kB
dist/esm/valtio.js 526 B
dist/esm/xstate.js 1.13 kB
dist/esm/zustand.js 284 B
dist/immer.js 732 B
dist/optics.js 938 B
dist/query.js 1.36 kB
dist/redux.js 314 B
dist/urql.js 1.54 kB
dist/utils.js 5.79 kB
dist/valtio.js 586 B
dist/xstate.js 1.19 kB
dist/zustand.js 344 B

compressed-size-action

@dai-shi dai-shi merged commit ce35b37 into main Dec 30, 2021
@dai-shi dai-shi deleted the fix/core/refactor-versioned-write branch December 30, 2021 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant