Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent reference missing, dispose #13

Merged
merged 4 commits into from
Mar 21, 2022
Merged

Fix parent reference missing, dispose #13

merged 4 commits into from
Mar 21, 2022

Conversation

eXponenta
Copy link
Contributor

@eXponenta eXponenta commented Mar 21, 2022 •
edited

Fix #12

Include fix for: #14

@eXponenta eXponenta changed the title Fix parent reference missing Fix parent reference missing, dispose Mar 21, 2022
@CodyJasonBennett
Copy link
Member

Looks good, waiting on oframe/ogl#123 for native dispose.

@CodyJasonBennett CodyJasonBennett merged commit 9459cc4 into pmndrs:main Mar 21, 2022
@CodyJasonBennett
Copy link
Member

Published in v0.1.3.

@eXponenta eXponenta deleted the patch-2 branch March 24, 2022 07:54
@CodyJasonBennett CodyJasonBennett mentioned this pull request Mar 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[critical] switching instance removes linkage to parent and drop attached node reference
2 participants
@eXponenta @CodyJasonBennett