Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Describe combining ref forwarding with animated #1734

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

gpoole
Copy link
Contributor

@gpoole gpoole commented Nov 3, 2021

Why

Resolves #1639 by documenting an issue with combining animated with forwardRef and explaining how to work around it.

What

I've updated the documentation to describe the problem in detail with examples and describe a workaround.

Checklist

  • Documentation updated
  • Ready to be merged

@vercel
Copy link

vercel bot commented Nov 3, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/6XKNEj4suG7RzUNZQa9U4jaCoSeK
✅ Preview: https://react-spring-io-git-fork-gpoole-patch-1-pmndrs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 3, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05c9370:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-animating-auto Configuration
spring-multistage-transition Configuration
spring-chain Configuration
spring-svg-filter Configuration
spring-css-keyframes Configuration
spring-tree Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
romantic-lovelace-1zwvv Issue #1639

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People who update documentation are the real MVP. Thanks for the contribution! ⭐

@joshuaellis joshuaellis merged commit 643b4a9 into pmndrs:master Nov 3, 2021
@gpoole
Copy link
Contributor Author

gpoole commented Nov 3, 2021

Thanks! Thanks @kindoflew for your research and the workaround.

@gpoole gpoole deleted the patch-1 branch November 3, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

animated does not work as expected on components also wrapped with forwardRef
2 participants