Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard funding mechanism #1740

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Nov 8, 2021

Why

See here: https://blog.opencollective.com/beyond-post-install/

Also fixes #1668

What

After this change you now use the "funding" field like everyone else.

Checklist

  • Ready to be merged

@vercel
Copy link

vercel bot commented Nov 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/4RFBPNsCj8QCrdrVrqSzcEsK9nDB
✅ Preview: https://react-spring-io-git-fork-flying-sheep-fix-funding-pmndrs.vercel.app

@flying-sheep flying-sheep changed the title Fix funding Use standard funding mechanism Nov 8, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8399713:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-animating-auto Configuration
spring-multistage-transition Configuration
spring-chain Configuration
spring-svg-filter Configuration
spring-css-keyframes Configuration
spring-tree Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration

@joshuaellis
Copy link
Member

Hm, it's not a like for like swap solution is it? Which is somewhat less than ideal.

@flying-sheep
Copy link
Contributor Author

flying-sheep commented Nov 8, 2021

I don’t know what that means. When running npm i, you’ll see a message “x packages are looking for funding”, and when you run npm fund, you see which ones.

It‘s not like this package is somehow special and deserves more or less attention than the other ones.

@joshuaellis joshuaellis merged commit e10f785 into pmndrs:master Nov 23, 2021
@flying-sheep flying-sheep deleted the fix-funding branch December 6, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advertisment in @react-spring/core/package.json breaks yarn 3
3 participants