Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update overflow css property without mixing shorthand and non-shorthand properties #1767

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

Lucasdsk
Copy link
Contributor

@Lucasdsk Lucasdsk commented Nov 23, 2021

Why

It fixes the following issue: #1766

Also, you can check an example here:
https://codesandbox.io/s/react-spring-parallax-issue-1766-f4iow?file=/src/App.js

What

I have changed the way the property overflow is provided to the Parallax component, instead of mixing the shorthand and the non-shorthand properties, I'm using only non-shorthand.

It will avoid this:
image

Checklist

  • Demo added
  • Ready to be merged

@vercel
Copy link

vercel bot commented Nov 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/react-spring-io/2Y4559JqtzkH54Jb8T81MSRWYGJ1
✅ Preview: https://react-spring-io-git-fork-lucasdsk-fix-update-styl-0cf036-pmndrs.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b31686a:

Sandbox Source
spring-card Configuration
spring-goo-blobs Configuration
spring-flip-card Configuration
spring-slide Configuration
spring-draggable-list Configuration
spring-cards-stack Configuration
spring-viewpager Configuration
spring-simple-transition Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-animating-auto Configuration
spring-multistage-transition Configuration
spring-chain Configuration
spring-svg-filter Configuration
spring-css-keyframes Configuration
spring-tree Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
react-spring/parallax - issue: 1766 PR

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @Lucasdsk! Great work 💪🏼

@joshuaellis joshuaellis merged commit e2be3a8 into pmndrs:master Nov 23, 2021
@Lucasdsk Lucasdsk deleted the fix/update-style-property branch November 23, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants