Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove infer S extends L #1988

Merged
merged 2 commits into from Sep 25, 2022
Merged

fix: remove infer S extends L #1988

merged 2 commits into from Sep 25, 2022

Conversation

joshuaellis
Copy link
Member

Why

What

  • make it more verbose by validating S extends L in ternary thus support TS < 4.7 again

Checklist

  • Ready to be merged

make it more verbose by validating S extends L in ternary
@vercel
Copy link

vercel bot commented Sep 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-spring-io ✅ Ready (Inspect) Visit Preview Sep 23, 2022 at 7:24AM (UTC)
1 Ignored Deployment
Name Status Preview Updated
react-spring-beta ⬜️ Ignored (Inspect) Sep 23, 2022 at 7:24AM (UTC)

@joshuaellis joshuaellis added the area: typescript Typescript issues label Sep 22, 2022
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 13d2505:

Sandbox Source
spring-animating-auto Configuration
spring-card Configuration
spring-cards-stack Configuration
spring-chain Configuration
spring-css-keyframes Configuration
spring-draggable-list Configuration
spring-exit-before-enter Configuration
spring-flip-card Configuration
spring-goo-blobs Configuration
spring-image-fade Configuration
spring-list-reordering Configuration
spring-masonry Configuration
spring-multistage-transition Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
spring-notification-hub Configuration
initial-rocket Configuration
spring-simple-transition Configuration
spring-svg-filter Configuration
spring-slide Configuration
spring-tree Configuration
spring-viewpager Configuration

@joshuaellis joshuaellis changed the base branch from master to beta September 23, 2022 07:14
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

🦋 Changeset detected

Latest commit: 13d2505

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@react-spring/core Patch
@react-spring/animated Patch
@react-spring/parallax Patch
@react-spring/rafz Patch
react-spring Patch
@react-spring/shared Patch
@react-spring/types Patch
@react-spring/konva Patch
@react-spring/native Patch
@react-spring/three Patch
@react-spring/web Patch
@react-spring/zdog Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript Typescript issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: TS < 4.8 project no longer compiles with spring ~9.5
1 participant