feat(docs): add r3f doc guide #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Be great to get thoughts and opinions from you both. |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Comment on lines
+170
to
+171
| const x = (e.offsetX / width) * 2 - 1 | ||
| const y = (e.offsetY / height) * -2 + 1 |
There was a problem hiding this comment.
I believe this NDC math is inbuilt into R3F's state model as pointer. I'd have to defer to @drcmda as for surrounding patterns but you could greatly reduce boilerplate with <Canvas onCreated={(state) => state.events.connect(window)} />.
krispya
reviewed
Oct 23, 2022
krispya
reviewed
Oct 23, 2022
krispya
reviewed
Oct 23, 2022
krispya
reviewed
Oct 23, 2022
Co-authored-by: Kris <kjbaumgartner@gmail.com>
Co-authored-by: Kris <kjbaumgartner@gmail.com>
Co-authored-by: Kris <kjbaumgartner@gmail.com>
|
I haven't replied to every comment, but overall, thank you both very much for your feedbacks. I won't be re-asking you to review (don't want to pest) but until the PR is merged / comments are resolved, please feel free to comment adhoc. |
joshuaellis
added
area: docs
and removed
area: three
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
r3fguide toreact-springdocumentation