refactor: improve algorithm

[CodyJasonBennett]

Rewrites the plugin and its test suite to handle member, dynamic, and template JSX expressions in addition to tree-shaking the default <Canvas />. This removes all of the limitations of the plugin, so I've opted to cleanup the README.

[mklasinc]

Is there perhaps a timeline estimate with regards to merging this PR to main? I think it's an awesome improvement and I'd be keen to try it out in production! 🙌

[CodyJasonBennett]

You can copy the source and pass it to Babel if you want to try right now, but unfortunately I just left a position where I wanted to field test this. Just integration testing for different tools and the effectiveness of tree-shaking, don't see any other blockers.

[umar-ahmed]

Is there perhaps a timeline estimate with regards to merging this PR to main? I think it's an awesome improvement and I'd be keen to try it out in production! 🙌

Gonna try to review this week 🤞. I don't see major blockers. But this is a rewrite of the logic and I want to make sure it's not breaking any existing use-cases.

[stilettk]

Hello! Is there any time estimate for this? It would be so great to use Canvas out-of-the-box with all of its features, and with the tree-shaking support!

[CodyJasonBennett]

I did a lot of plumbing work upstream with tree-shaking and can verify that works as intended with https://github.com/CodyJasonBennett/treeshake-cli. extend calls are not inlined for the moment.

[stilettk]

I'm taking about using Canvas, as mentioned here: #9 (comment). What you mean is that you have tested default Canvas with treeshake-cli, and tree-shaking works as expected? I'm asking because the screenshot shows only Vector import.

[CodyJasonBennett]

The previous blockers for this PR was whether it produces valid code after tree-shaking (mostly important for libraries which use this plugin) and is configurable between build tools. I've cleared both so it's just pending review from @umar-ahmed.

[umar-ahmed]

Committing to reviewing this weekend. You have my permission to keep pinging me to get it to the finish line 😛

[umar-ahmed]

@CodyJasonBennett Looks good overall. I had a couple comments/questions. But I think we can get this merged and released soon.

We did lose one bit of functionality, which is being able to import components from packages other than three. I think it's fine if we omit this for now, but I just wanted to call it out for future readers.

[CodyJasonBennett]

We did lose one bit of functionality, which is being able to import components from packages other than three. I think it's fine if we omit this for now, but I just wanted to call it out for future readers.

I didn't understand this use-case or the need to begin with rather. This plugin assumes a well-formed program which means it must be portable with/without it.

[umar-ahmed]

Published to NPM and created a release on GitHub: https://github.com/pmndrs/react-three-babel/releases/tag/v1.0.0