Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to React 18 #79

Merged
merged 1 commit into from Apr 17, 2022
Merged

Upgrade to React 18 #79

merged 1 commit into from Apr 17, 2022

Conversation

giulioz
Copy link
Member

@giulioz giulioz commented Apr 17, 2022 •
edited

Fixes #78

@giulioz giulioz mentioned this pull request Apr 17, 2022
Closed
@talentlessguy
Copy link
Member

Netlify seems to fail because of "engines" of some package

@giulioz
Copy link
Member Author

giulioz commented Apr 17, 2022

Any idea on how to fix it?

@talentlessguy
Copy link
Member

we need to bump Node.js version on netlify somehow

@talentlessguy
Copy link
Member

anyways i'll merge it

@talentlessguy talentlessguy merged commit ec95e71 into master Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talentlessguy talentlessguy talentlessguy approved these changes

@saitonakamura saitonakamura Awaiting requested review from saitonakamura

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript errors with r3f v8
2 participants
@giulioz @talentlessguy