Added unit tests for XREvents #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saitonakamura
force-pushed
the
xr-events-test
branch
from
3e5a7bd
to
515ffde
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit af21748:
|
saitonakamura
force-pushed
the
xr-events-test
branch
from
515ffde
to
34d697c
Compare
this way it'll be easier to mock a store provider without exposing XRContext to the outside
had to make private XRController fields public because of weird Typescript behaviour: implementing a class requires to implement private fields, but now adequate way to do so
saitonakamura
force-pushed
the
xr-events-test
branch
from
34d697c
to
af21748
Compare
|
Tested examples on codesandbox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to refactor the code a bit to a make it more handy to test, but no big changes
Contribution is sponsored by Mayflower