fix: modernize & tree-shake #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 504107d:
|
CodyJasonBennett
force-pushed
the
fix/tree-shake
branch
from
1dd5869
to
de4834d
Compare
CodyJasonBennett
force-pushed
the
fix/tree-shake
branch
from
21414bc
to
a7ac688
Compare
This was referenced May 26, 2023
|
🎉 This PR is included in version 2.22.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Fixes #114
Fixes #237
Fixes #244
Some examples still used prototype hacks or were missing pure annotations for module side-effects. I've opted to upstream older examples and their types which received no breaking changes, but fixes and improvements. Some modules also had missing types.
Notes:
src/offscreenwasn't exported, so I've opted to remove them since they have no utility.src/nodesandsrc/renderers/webgpuare defunct and based on a now non-existent WebGPU standard. These rely on prototype hacks which breaks WebGL code and can't be removed without changes in the three.js core. This is also very old, SPIR-V support was removed years ago for WGSL, so we won't need@webgpu/glslangeither. I've also opted to remove them, but I question whether this is breaking since it's both not used in userland and fixes issues with the library.TODO: