Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(BatchedMesh): move render hooks to constructor for dts #311

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

CodyJasonBennett
Copy link
Member

Fixes #310 by moving the usage of member properties for render hooks to the constructor.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 07166ef:

Sandbox Source
Vanilla Configuration

@CodyJasonBennett CodyJasonBennett merged commit e7b3328 into main Oct 24, 2023
1 check passed
@CodyJasonBennett CodyJasonBennett deleted the fix/batchedmesh-hooks branch October 24, 2023 00:32
@github-actions
Copy link

🎉 This PR is included in version 2.28.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onBeforeRender in BatchedMesh causes TS error
1 participant