Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): remove references to Shader type #327

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Dec 23, 2023

Why

The types have errors when used with @types/three@0.160.0, because the Shader type was removed in @types/three@0.160.0 due it it being used in ways it wasn't intended to be used. The type errors are:

Error: ./node_modules/three-stdlib/postprocessing/ShaderPass.d.ts(1,10): error TS2305: Module '"three"' has no exported member 'Shader'.
Error: ./node_modules/three-stdlib/shaders/types.d.ts(1,25): error TS2305: Module '"three"' has no exported member 'Shader'.

What

Remove use of the Shader type with more suitable types.

Checklist

  • Ready to be merged

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Methuselah96 Methuselah96 changed the title Remove references to Shader type fix(types): remove references to Shader type Dec 23, 2023
@CodyJasonBennett
Copy link
Member

Thanks.

@CodyJasonBennett CodyJasonBennett merged commit 8449f8e into pmndrs:main Dec 23, 2023
3 checks passed
Copy link

🎉 This PR is included in version 2.28.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@Methuselah96 Methuselah96 deleted the remove-shader-type branch December 23, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants