Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): minimize types by deprecating them #1089

Merged
merged 1 commit into from Jul 17, 2022

Conversation

devanshj
Copy link
Contributor

@devanshj devanshj commented Jul 15, 2022

I've done the initial deprecation work, the following work is up for grabs...

  • Migrate the whole codebase to not use deprecated types
  • Consider reordering exports in a way the deprecated types are exported at the bottom, it might affect the user's autocomplete and show more useful types first.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d336c61:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration
Next.js Configuration

@dai-shi
Copy link
Member

dai-shi commented Jul 15, 2022

  • Migrate the whole codebase to not use deprecated types
  • Consider reordering exports in a way the deprecated types are exported at the bottom, it might affect the user's autocomplete and show more useful types first.

Sounds good!

@dai-shi dai-shi changed the title types: minimize types by deprecating them feat(types): minimize types by deprecating them Jul 15, 2022
@dai-shi dai-shi added this to the v4.0.0 milestone Jul 15, 2022
@dai-shi
Copy link
Member

dai-shi commented Jul 17, 2022

  • Migrate the whole codebase to not use deprecated types
  • Consider reordering exports in a way the deprecated types are exported at the bottom, it might affect the user's autocomplete and show more useful types first.

Let's work on them in separate PRs. Anyone interested?

@dai-shi dai-shi added the help wanted Please someone help on this label Jul 17, 2022
@dai-shi dai-shi merged commit 93ee103 into pmndrs:main Jul 17, 2022
@dai-shi dai-shi removed the help wanted Please someone help on this label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants