Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix broken links on readme #1230

Merged
merged 2 commits into from Aug 28, 2022
Merged

Conversation

radaelilucca
Copy link
Contributor

Fixes some broken links on readme, mostly files that were moved to a subfolder of ./docs.

Check List

  • yarn run prettier for formatting code and docs

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 26, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a706116:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

readme.md Outdated
- [Calling actions outside a React event handler in pre React 18](docs/event-handler-in-pre-react-18.md).
- You may wonder how to organize your code for better maintenance: [Splitting the store into separate slices](./docs/guides/typescript.md#slices-pattern).
- Recommended usage for this unopinionated library: [Flux inspired practice](./docs/guides/flux-inspired-practice.md).
- [Calling actions outside a React event handler in pre React 18](./docs/guides/event-handler-in-pre-react-18.md).
- Testing: [Wiki page](https://github.com/pmndrs/zustand/wiki/Testing).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this link directly to the guide? eg: ./docs/guides/testing.mdx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right! Fixed!

@dai-shi dai-shi merged commit a413f4a into pmndrs:main Aug 28, 2022
@dai-shi dai-shi mentioned this pull request Aug 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants